Skip to content

Split codegen backend check step into two and don't run it with x check compiler #145340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Split codegen backend check step into two and don't run it with x check compiler #145340

wants to merge 1 commit into from
+91 −170

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Aug 13, 2025

This reduces the amount of work that is done during x check compiler. We still check both backends during x check by defaut, even if they are not in rust.codegen-backends, as just checking them shouldn't require expensive preparations, like building GCC.

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 13, 2025
jieyouxu
jieyouxu approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yeah it always felt a bit strange when ./x check compiler checks cg backends 👍

src/bootstrap/src/core/build_steps/check.rs Outdated
impl Step for GccCodegenBackend {
type Output = ();

const ONLY_HOSTS: bool = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: will conflict with #145324

@jieyouxu
Copy link
Member

You can r=me after #145324 merges with a rebase (and rename to IS_HOST).

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2025
@jieyouxu jieyouxu mentioned this pull request Aug 13, 2025
Open
@bors
Copy link
Collaborator

bors commented Aug 14, 2025

☔ The latest upstream changes (presumably #145131) made this pull request unmergeable. Please resolve the merge conflicts.

@Kobzol Kobzol force-pushed the bootstrap-codegen-backend-check-split branch from 819462e to 2a2903c Compare August 15, 2025 06:19
@Kobzol
Copy link
Member Author

Kobzol commented Aug 15, 2025

Rebased.

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Aug 15, 2025

📌 Commit 2a2903c has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kobzol @rustbot @jieyouxu @bors